Bugfix/CSTACKEX-129 Primary storage-pool is not failing even if NFS3/ISCSI protocol is not enabled at the storage VM#61
Open
suryag1201 wants to merge 13 commits into
Open
Bugfix/CSTACKEX-129 Primary storage-pool is not failing even if NFS3/ISCSI protocol is not enabled at the storage VM#61suryag1201 wants to merge 13 commits into
suryag1201 wants to merge 13 commits into
Conversation
added 11 commits
May 22, 2026 11:57
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
…protocol is not enabled at the storage VM
suryag1201
requested review from
piyush5netapp,
rajiv-jain-netapp and
sandeeplocharla
as code owners
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| public static class ProtocolStatus { |
There was a problem hiding this comment.
Why do we need a static class for this? Instead, could we consider using a simple boolean parameter rather than introducing a complex type that itself only contains a boolean field?
added 2 commits
May 25, 2026 19:29
… protocol is not enabled at the SVM
… protocol is not enabled at the SVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Primary storage-pool is not failing even if NFS3/ISCSI protocol is not enabled at the storage VM
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?